Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multifence-validation): allow old AND new style id tokens #943

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

vpsx
Copy link
Contributor

@vpsx vpsx commented Jul 1, 2021

There exist people running multi Fence with two modern Fences!

Jira Ticket: n/a

Bug Fixes

  • Fix ID token validation for multi-tenant Fence setup: Allow both old and new style ID tokens
  • Fix ID token validation for multi-tenant Fence setup: Client Fence should demand its client_id, not its BASE_URL, in the aud claim

* There exist people running multi Fence with two modern Fences!
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Jul 1, 2021

Pull Request Test Coverage Report for Build 11341

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 71.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/login/fence_login.py 3 5 60.0%
Totals Coverage Status
Change from base Build 11333: -0.01%
Covered Lines: 6199
Relevant Lines: 8730

💛 - Coveralls

@paulineribeyre paulineribeyre merged commit 3a7d285 into master Jul 9, 2021
@paulineribeyre paulineribeyre deleted the fix/multifence-validation branch July 9, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants