Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-8492: Download Error for Anonymous User #955

Merged
merged 12 commits into from
Sep 7, 2021
Merged

PXP-8492: Download Error for Anonymous User #955

merged 12 commits into from
Sep 7, 2021

Conversation

MaribelleHGomez
Copy link
Contributor

@MaribelleHGomez MaribelleHGomez commented Aug 16, 2021 •
edited
Loading

Jira Ticket: PXP-8492

New Features

Breaking Changes

Bug Fixes

  • A change in the gen3cirrus package for the get_signed_url function was made, the function parameters were not updated in fence and returned an invalid parameter error. Adding missing parameters to the function in Fence resolved error.

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@MaribelleHGomez MaribelleHGomez changed the title PXP-8492: Fix/anonymous download PXP-8492: Download Error for Anonymous User Aug 16, 2021
@coveralls
Copy link

coveralls commented Aug 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 11658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.125%
Totals Coverage Status
Change from base Build 11636: 0.0%
Covered Lines: 6448
Relevant Lines: 8940
💛 - Coveralls

@BinamB
Copy link
Contributor

BinamB commented Sep 3, 2021

Lgtm! Dont forget to update your branch!

@MaribelleHGomez MaribelleHGomez merged commit e9f0d48 into master Sep 7, 2021
@MaribelleHGomez MaribelleHGomez deleted the fix/anonymous_download branch September 7, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinamB BinamB BinamB approved these changes

Assignees
No one assigned
Labels
test-apis-drsEndpointsTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaribelleHGomez @coveralls @BinamB @PlanXCyborg