(PXP-8992): Expire user policies and update Arborist username #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 12056
💛 - Coveralls |
Avantol13
reviewed
Nov 29, 2021
fence/sync/sync_users.py
Outdated
| @@ -1664,6 +1666,9 @@ def _update_authz_in_arborist( | |||
| policy_id_list = [] | |||
| policies = [] | |||
|
|
|||
| if expires is not None: | |||
| expires = datetime.datetime.utcfromtimestamp(expires) | |||
There was a problem hiding this comment.
Avantol13
requested changes
Nov 29, 2021
fence/resources/openid/ras_oauth2.py
Outdated
| @@ -206,7 +206,11 @@ def map_iss_sub_pair_to_user(self, issuer, subject_id, username, email): | |||
| "from the DRS endpoint. Changing said user's username" | |||
| f' to "{username}".' | |||
| ) | |||
| # TODO also change username in Arborist | |||
| flask.current_app.arborist.update_user( | |||
There was a problem hiding this comment.
I think we need to handle the error here? or, I see you raise exception in this function. maybe there's not much we can actually do if this fails... but we should at least catch the exception and log useful information (and not implicitly rely on the library to do that). If it's relatively simple, we could try some simple backoff to retry one more time maybe?
Avantol13
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-8992
New Features
Dependency updates