feat(oauth): make discovery url and scope configurable per client and… #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… override defaults with configuration
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 12098
💛 - Coveralls |
| @@ -149,6 +151,7 @@ OPENID_CONNECT: | |||
| # ORCID.org. DO NOT include {{BASE_URL}} at ORCID.org, you need to actually put the | |||
| # full url | |||
| redirect_url: '{{BASE_URL}}/login/orcid/login/' | |||
| scope: 'openid' | |||
| # if mock is true, will fake a successful login response for login | |||
There was a problem hiding this comment.
Maybe orcid's discovery_url could be added here as well?
johnfrancismccann
previously approved these changes
Dec 7, 2021
Avantol13
dismissed stale reviews from johnfrancismccann and BinamB
via
b7fdcb2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… override defaults with configuration
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes