fix(tests): remove swagger-codegen dependecy #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
callenmacphee
force-pushed
the
test/improve-test-coverage
branch
from
1984970
to
171fc86
Compare
paulineribeyre
requested changes
Jul 29, 2019
There was a problem hiding this comment.
very cool! 80% coverage 🎉
a general comment: adding assert res.status_code == 200 after each get/post/put/patch/delete operation is good practice. especially after the post steps in your case, since the rest of the test is counting on the record being there
please also have a look at what Codacy is complaining about!
callenmacphee
force-pushed
the
test/improve-test-coverage
branch
from
fa8931b
to
6fdb91d
Compare
paulineribeyre
requested changes
Jul 31, 2019
paulineribeyre
requested changes
Jul 31, 2019
…d into test/improve-test-coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for swagger-codegen language removal from testing to get more accurate reading on coveralls. Conftest has been stripped of swagger_client fixtures. Tests previously dependent on swagger_client fixtures now depend on client and user fixtures.
Improvements