HSClient handling #253
Merged
HSClient handling #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(dos): errors
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
itsJiaqi
reviewed
Nov 21, 2019
| @@ -120,22 +127,26 @@ def indexd_to_dos(record): | |||
|
|
|||
| @blueprint.errorhandler(UserError) | |||
| def handle_user_error(err): | |||
| return flask.jsonify(error=str(err)), 400 | |||
| ret = {"msg": str(err), "status_code": 400} | |||
There was a problem hiding this comment.
why do you need to return the status code also in the response data?
There was a problem hiding this comment.
i don't know why it was done this way, but a production website is using a branch with this change so i'd rather not change the contents of the response
itsJiaqi
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataguids.org uses the feat/hs branch - merge it into master so that we can pin dataguids.org
New Features