Fix/upgrade flask #371
Merged
Fix/upgrade flask #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
k-burt-uch
previously approved these changes
Oct 31, 2023
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-metadataIngestionTest
test-apis-oidcClientTest
test-coremetadata-getCoremetadataTest
test-portal-coremetadatapageTest
test-sheepdogAndPeregrine-submitFileTest
and removed
@requires-indexd
test-sheepdogAndPeregrine-submitFileTest
test-apis-centralizedAuth
test-coremetadata-getCoremetadataTest
test-portal-coremetadatapageTest
test-apis-oidcClientTest
labels
paulineribeyre
previously approved these changes
Nov 2, 2023
PlanXCyborg
added
test-coremetadata-getCoremetadataTest
test-portal-coremetadatapageTest
test-sheepdogAndPeregrine-submitAndQueryNodesTest
test-sheepdogAndPeregrine-submitFileTest
and removed
test-sheepdogAndPeregrine-submitAndQueryNodesTest
test-sheepdogAndPeregrine-submitFileTest
test-portal-coremetadatapageTest
labels
k-burt-uch
previously approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Outside of the flask version update and poetry lock, the only other change is ensuring Basic authorization is used before going through the username/password authz path rather than just relying on the presence of the authorization header in the request.
Approved.
george42-ctds
commented
Nov 14, 2023
| current_app.auth.auth( | ||
| request.authorization.username, request.authorization.password | ||
| request.authorization.parameters.get("username"), | ||
| request.authorization.parameters.get("password"), |
There was a problem hiding this comment.
This change is needed after upgrading werkzeug (upgrades to Authorization object).
paulineribeyre
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PPS-655
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes