Fix/fix linter errors (#34)

* (PXP-10137): log errors, use 'Fprint' instead of 'Fprintf'.

* (PXP-10137): merge declaration and initialization of 'batchJob'.

* (PXP-10137): specify go version to match go.mod.

.github/workflows/golang-ci-workflow.yaml

@@ -6,6 +6,7 @@ jobs:
   ci:
     runs-on: ubuntu-latest
     env:
+      GO_VERSION: "1.17"
       COVERAGE_PROFILE_OUTPUT_LOCATION: "./profile.cov"
     steps:
       - name: Checkout code / lint code / install dependencies for goveralls / run tests

handlers/jobs.go

@@ -188,11 +188,9 @@ func createK8sJob(currentAction string, inputData string, accessFormat string, a
 	var volumeMounts []k8sv1.VolumeMount
 	volumeMounts = append(volumeMounts, conf.Container.VolumesMounts...)
 
-	var batchJob *batchv1.Job
-
 	// For an example of how to create jobs, see this file:
 	// https://github.com/pachyderm/pachyderm/blob/805e63/src/server/pps/server/api_server.go#L2320-L2345
-	batchJob = &batchv1.Job{
+	var batchJob *batchv1.Job = &batchv1.Job{
 		TypeMeta: metav1.TypeMeta{
 			Kind:       "Job",
 			APIVersion: "v1",
@@ -277,7 +275,13 @@ func getPodMatchingJob(jobname string) *k8sv1.Pod {
 	}
 	// creates the clientset
 	clientset, err := kubernetes.NewForConfig(config)
+	if err != nil {
+		log.Errorf("Failed to create clientset.\nError: %s", err.Error())
+	}
 	pods, err := clientset.CoreV1().Pods(kubectlNamespace).List(context.TODO(), metav1.ListOptions{})
+	if err != nil {
+		log.Errorf("Failed to create pods.\nError: %s", err.Error())
+	}
 	for _, pod := range pods.Items {
 		if strings.HasPrefix(pod.Name, jobname) {
 			return &pod
@@ -304,6 +308,9 @@ func getJobLogs(jobid string, username string) (*JobOutput, error) {
 	}
 	// creates the clientset
 	clientset, err := kubernetes.NewForConfig(config)
+	if err != nil {
+		log.Errorf("Failed to create clientset.\nError: %s", err.Error())
+	}
 	podLogOptions := k8sv1.PodLogOptions{}
 	req := clientset.CoreV1().Pods(pod.Namespace).GetLogs(pod.Name, &podLogOptions)
 	podLogs, err := req.Stream(context.TODO())

handlers/sower.go

@@ -84,7 +84,7 @@ func dispatch(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	fmt.Fprintf(w, string(out))
+	fmt.Fprint(w, string(out))
 }
 
 func status(w http.ResponseWriter, r *http.Request) {
@@ -186,7 +186,7 @@ func list(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	fmt.Fprintf(w, string(out))
+	fmt.Fprint(w, string(out))
 }
 
 func getBearerToken(r *http.Request) *string {

handlers/system.go

@@ -19,7 +19,7 @@ func RegisterSystem() {
 }
 
 func systemStatus(w http.ResponseWriter, r *http.Request) {
-	fmt.Fprintf(w, "Healthy")
+	fmt.Fprint(w, "Healthy")
 }
 
 func systemVersion(w http.ResponseWriter, r *http.Request) {
@@ -30,5 +30,5 @@ func systemVersion(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	fmt.Fprintf(w, string(out))
+	fmt.Fprint(w, string(out))
 }