[PXP-8941] [PXP-8859] Feat/update go 1.17 #25
Conversation
m0nhawk
requested review from
mfshao and
themarcelor
and removed request for
themarcelor
| return nil, fmt.Errorf("Unexpected signing method: %v", token.Header["alg"]) | ||
| } | ||
| func getEmailFromToken(accessTokenVal string) (string, error) { | ||
| jwksURL := "http://fence-service/.well-known/openid-configuration" |
There was a problem hiding this comment.
should http://fence-service be a config default instead of hardcoded?
There was a problem hiding this comment.
This does makes sense... But I'm not sure we really need this. Is there a scenario where the fence pod is not running under fence-service?
There was a problem hiding this comment.
if we run the service locally, or in an ecosystem setup like we used to have for NIAID NDE (sub-commons microservices talking to a central fence). But maybe it's too YAGNI 🙂
There was a problem hiding this comment.
For running locally, it should be OK (I’m the context of compose-services, for example).
I’m case of NIAID NDE, I’m not sure on the implications… it’s really depends on who issues the access token for the user and where it runs.
There was a problem hiding this comment.
@paulineribeyre I would say — let's merge this for now, and keep an eye on if this will be needed by anyone.
m0nhawk
changed the title
m0nhawk
changed the title
Jira Ticket: PXP-8941
Jira Ticket: PXP-8859
New Features
Breaking Changes
Bug Fixes
x509: certificate signed by unknown authorityImprovements
Dependency updates
Deployment changes
PS: This is follow-up on this one: #24