Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "-all1" option will test the fxx_mulAdd, which is not a unary function #7

Closed
RolfyYu opened this issue Nov 2, 2017 · 3 comments

Comments

@RolfyYu
Copy link

RolfyYu commented Nov 2, 2017

In "testfloat.c":
line 1683~1686, fxx_mulAdd is not labeled as "FUNC_ARG_BINARY",
so the code logic will put fxx_mulAdd into all1 list.

@jhauser-ucberkeley
Copy link
Contributor

You're absolutely right about the bug, though not about the correct fix, since the multiply-add functions aren't binary either.

This was made to work properly in testsoftfloat a long time ago, but I evidently forgot to upgrade testfloat at the same time. As it happens, I'm already working on the next release (3e). I'll include the correction for this issue in that realease.

@jhauser-ucberkeley
Copy link
Contributor

This mistake is believed to be fixed in Release 3e.

@RolfyYu RolfyYu closed this as completed Jul 26, 2018
@RolfyYu
Copy link
Author

RolfyYu commented Jul 26, 2018

confirm that -all1 option is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants