Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torture Test is failing after removing the Floating Point Unit #1887

Closed
3 tasks done
ashu-bitspilani opened this issue May 28, 2024 · 2 comments
Closed
3 tasks done
Labels

Comments

@ashu-bitspilani
Copy link

ashu-bitspilani commented May 28, 2024

Background Work

Chipyard Version and Hash

Release: 1.5.0
Hash: a6a6a6

OS Setup

Ex: Output of uname -a + lsb_release -a + printenv + conda list

Other Setup

Ex: Prior steps taken / Documentation Followed / etc...

Current Behavior

I have removed the FPU from the RocketCore.
This is the configuration I have used to remove it.

class WithNBigCores(
  n: Int,
  overrideIdOffset: Option[Int] = None,
  crossing: RocketCrossingParams = RocketCrossingParams()
) extends Config((site, here, up) => {
  case TilesLocated(InSubsystem) => {
    val prev = up(TilesLocated(InSubsystem), site)
    val idOffset = overrideIdOffset.getOrElse(prev.size)
    val big = RocketTileParams(
    core   = RocketCoreParams(fpu = None),

It has been completely removed as I have checked the RTL.

Expected Behavior

But the torture test running is fine with FPU Configuration.

image

But it is failing with without FPU Configuration

image

Can someone help how to run torture after removing the FPU

Other Information

No response

@jerryz123
Copy link
Contributor

You likely have to configure torture to not omit FP instructions. You can figure out how to do that through the documentation and source code of torture.

@ashu-bitspilani
Copy link
Author

ashu-bitspilani commented Jun 4, 2024

@jerryz123
I have entirely removed the FP instruction from torture and also checked that there is no freg register and FP-related instruction generated in the test.S file. But still, my torture test is getting failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants