Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Directory collisions may confuse users #57

Open
chick opened this issue Aug 21, 2019 · 1 comment
Open

Test Directory collisions may confuse users #57

chick opened this issue Aug 21, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@chick
Copy link
Contributor

chick commented Aug 21, 2019

A nice feature of Testers2 is that it bases the name of the work directory for a test from the scalaTest test name. This can lead to potential collisions if two different tests share the same tests name.
Proposed fix, incorporate class name of test into the test directory
Example

class X extends FreeSpec with ChiselScalatestTester {
  "basic compile should work" in {}
}
class Y extends FreeSpec with ChiselScalatestTester {
  "basic compile should work" in {}
}

The working directory for both these tests will be the same, i.e. "test_run_dir/basic_compile_should_work".
It might not matter but it can create weird errors if the the two tests are similar and have different backends.

@chick chick added the enhancement New feature or request label Aug 21, 2019
@chick chick self-assigned this Aug 21, 2019
@ducky64
Copy link
Member

ducky64 commented Aug 21, 2019

That sounds reasonable. Not sure if there was a reason it's not currently being prefixed with the class name, but I don't think so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants