Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect allowed on inputs, poke allowed on outputs #8

Closed
chick opened this issue Dec 3, 2018 · 3 comments
Closed

Expect allowed on inputs, poke allowed on outputs #8

chick opened this issue Dec 3, 2018 · 3 comments
Assignees
@chick
Labels
bug Something isn't working

Comments

@chick
Copy link
Contributor

chick commented Dec 3, 2018

Expect allowed on inputs and poke allowed on outputs seems like this should warn or error.
@chick chick added the bug Something isn't working label Dec 3, 2018
@chick chick self-assigned this Dec 3, 2018
@ducky64
Copy link
Member

ducky64 commented Dec 3, 2018

I think expect on inputs can make sense, but poke on outputs should not be.

@edwardcwang
Copy link
Member

Yeah poke on output sounds fishy.

@ducky64
Copy link
Member

ducky64 commented Dec 5, 2018

Should be fixed now, poking outputs will now throw an UnpokeableException.

@ducky64 ducky64 closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chick chick

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chick @ducky64 @edwardcwang