Support for Decoupled/Valid with zero-width data #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures seem to be completely unrelated. (One is probably a bug in Verilator caching?) |
|
Thanks for the PR. I think there might be a more general solution for 0-bit wires which is why I would rather not merge this yet. |
ekiwi
force-pushed
the
enqueue_option
branch
2 times, most recently
from
d8d04a9
to
68e2038
Compare
|
@kammoh Could you have a look at my changes and see if this addresses your problem? I did remove your option to pass |
Co-authored-by: Kamyar Mohajerani <kammoh@gmail.com>
ekiwi
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #35,
chiseltestdoes not currently support zero-width data/ports.This PR provides a solution (well, maybe a workaround) specific to
DecoupledandValidinterfaces. Decoupled interfaces with zero-width data can also be used
as a control/synchronization handshake where no data exchange is required.
Here we take an explicit approach: the designer knows the
width of data at instantiation and can accordingly utilize appropriate
Option[Data]values.