Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of deprecated SecurityManager #13

Merged
merged 3 commits into from
May 6, 2023
Merged

Conversation

vighneshiyer
Copy link
Contributor

The Java SecurityManager has been deprecated and any usage of it throws an error with JDK 19+. It is also a big hack to capture System.exit(), so now Stage.main is split into main (which calls mainInner and System.exit) and mainInner (which just returns an Int).

@vighneshiyer vighneshiyer requested a review from ekiwi May 6, 2023 00:38
Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner

@ekiwi ekiwi merged commit 811d767 into main May 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants