Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a possible description error in Readme file #139

Closed
Celtyee opened this issue Jul 5, 2021 · 1 comment
Closed

a possible description error in Readme file #139

Celtyee opened this issue Jul 5, 2021 · 1 comment

Comments

@Celtyee
Copy link

Celtyee commented Jul 5, 2021

Hello,
ps: It is only a small issue, not making influence on implementation of Gemmini.

I think the action description on mvout, which is Action: DRAM[Translate[rs2]] <= Scratchpad[rs1] , should exchange the position of r1 and r2, changing into Action: DRAM[Translate[rs1]] <= Scratchpad[rs2]
By definition, r1 is the virtual DRAM address, and r2 is the S_pad address.
And according to the test example in mvin_mvout.c:

for (size_t n = 0; n < N; ++n) {
// printf("Mvin %d\n", n);
gemmini_mvin(In[n], nDIM);
// printf("Mvout %d\n", n);
gemmini_mvout(Out[n], n
DIM);
}

We store the information of In matrix into sp[n*DIM] rather than sp[Out[n]]

hngenc added a commit that referenced this issue Jul 8, 2021
Fixes issue #139, as noticed by @Lyon-ai
@hngenc
Copy link
Member

hngenc commented Jul 8, 2021

You are correct, and I've just fixed this in dev. Thank you for catching this!

@hngenc hngenc closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants