Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Typechecker from mypy to pyright #850

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Switch Typechecker from mypy to pyright #850

merged 4 commits into from
Mar 13, 2024

Conversation

vighneshiyer
Copy link
Contributor

Pyright is a Python typechecker and LSP that is faster and has tighter IDE integration vs mypy. It also doesn't require weird hacks for ruamel and networkx to typecheck. It also is a bit more strict than mypy. This was just a fun experiment to see what things pyright might catch that mypy doesn't. Feel free to investigate and merge if you'd like.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! This looks like a pretty straightforward migration. What's still left to do (i.e. why is it in draft)?

hammer/vlsi/hammer_tool.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@harrisonliew harrisonliew added this pull request to the merge queue Mar 13, 2024
Merged via the queue into master with commit 60ac826 Mar 13, 2024
4 checks passed
@harrisonliew harrisonliew deleted the pyright branch March 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants