Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SimpleWebServer to the latest version(29 Apr, 2019 - d6985ed6) #691

Merged
merged 3 commits into from
May 14, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo commented May 12, 2019

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1951/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1952/
Test PASSed.

Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I appreciate you added [CLIPPER] comment line so that we can easily update the part whenever we update this dependency.

Everything looks good to me, but I have a few questions.

  1. Aren't we using C++ formatter anymore? I found some parts of code were formatted in the previous SimpleWebServer V2.1.1.
  2. This version (d6985) is literally the newest commit of SimpleWebServer. Do you think it is stable enough? I am afraid we have to keep updating the version because the newest master is unstable. Is it the version your team is currently using?

};

public:
// [CLIPPER]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found in the previous code, these were formatted (I believe we ran the formatter before?). We don't use the C++ formatter anymore? @simon-mo @withsmilo

@withsmilo
Copy link
Collaborator Author

@rkooo567

  1. AFAIK, the C++ code formatter is turned off now.
  2. We cannot use SimpleWebServer V2.1.1 in the production environment because it has [Bug] SIGSEGV occurred in the SimpleWebServer very rarely #551 issue. Our team is using ver3(21 Sep, 2018 - cfe98038), and will test / update to the latest ver(29 Apr, 2019 - d6985ed6) this week. I think that there will not be a big problem because the changes applied between them are very minor. Please wait for the test result to run for a week.

OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/

#ifndef SERVER_HTTP_HPP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add a README.md to record the version/revision hash information? Seems like some C++ dependencies keep track of its version in its directory name, but httpserver does not. I believe it is because we have some additional custom code inside. We can also probably mention whenever we update the version of httpserver, we should remain the parts with // [CLIPPER].

@simon-mo
Copy link
Contributor

Thanks! I'll directly merge this one since test passed already.

@simon-mo simon-mo merged commit 28ad2b2 into ucbrise:develop May 14, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1960/
Test PASSed.

@withsmilo withsmilo deleted the update_simple_web_server branch May 14, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants