Feat/replay

[bobbyyyan]

• fix no-op when no args passed
• add support for literals

[rlnsanz]

Hi Bobby, good catch on returning literal values. Let's set up a time to talk and go through design options before merging. I prefer for the developer to specify whether to return a value or update an argument's state.

flor.skipblock.end(args, values=[...]
Here, args is a tuple of objects whose states are updated.
Values is what we mean to return.

Example.
favorite_int = 99
...
favorite_int = flor.SkipBlock.end(net, optimizer, values=[favorite_int,])

We can discuss during our call. Thanks!!

[rlnsanz]

Thanks for your work implementing the logger Bobby. The logger is looking solid and it has a good interface. Thank you.

I would like for you to separate the ReadBlock refactor and feature extension from the logger implementation please. That will facilitate design, discussion, and debugging and testing. I didn't really read over the ReadBlock changes. Please submit a PR for the logger only ignoring ReadBlock modifications, then during our 1:1 we can discuss possible ReadBlock extensions as necessary.

Please also address comments about code deduplication.

Thanks again!

[rlnsanz]

Isn't this function already defined elsewhere in the code? Can we avoid code duplication here? Have the code block be defined in a single spot and used in multiple spots.

[bobbyyyan]

I couldn't find where it's duplicated. Mind pointing me to it?

[rlnsanz]

I think I see what you're doing here. You're being clear about the code that gets run on pre. But the user won't be changing the Flor code base, so this show-and-tell format is better off in a readme or Docs.

[bobbyyyan]

I'm not too sure what you mean by "show-and-tell format." It's registering a preprocessing step particular to entries_logger but not all loggers.

[bobbyyyan]

Hi Bobby, good catch on returning literal values. Let's set up a time to talk and go through design options before merging. I prefer for the developer to specify whether to return a value or update an argument's state.

flor.skipblock.end(args, values=[...]
Here, args is a tuple of objects whose states are updated.
Values is what we mean to return.

Example.
favorite_int = 99
...
favorite_int = flor.SkipBlock.end(net, optimizer, values=[favorite_int,])

We can discuss during our call. Thanks!!

For completeness, the argument against

favorite_int = flor.SkipBlock.end(net, optimizer, values=[favorite_int,])

is that it puts the burden on the user to determine what's pass-by-value.

For example, it's not clear if

favorite_int, optimizer = flor.SkipBlock.end(net, values=[favorite_int, optimizer])

should yield the same behavior as if

favorite_int = flor.SkipBlock.end(net, optimizer, values=[favorite_int,])

were called.