New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pixel Viewer interactive to support edge detection #388

Merged
merged 13 commits into from Feb 12, 2018

Conversation

2 participants
@JackMorganNZ
Member

JackMorganNZ commented Sep 28, 2016

Proposed changes

This pull request merges in the work by Andrew Bell on updating the pixel viewer interactive to do edge detection. The logic has been added by the interface needs to be updated for improved usability.

Also this pull request has merge conflicts because the structure of the CSFG has changed since the work began.

This pull request is also the follow up/next step for #32.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the pull request. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your change.

  • I have read the contribution guidelines
  • I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number)
  • I have applied the relevant labels for this change
  • I have run the generation script and checked the output
  • I have added necessary documentation (if appropriate)

Andrew Bell added some commits Apr 6, 2016

Andrew Bell
Added feature for thresholding. Open with option mode=threshold to
activate. Turns pixels white or black based on a boolean equation
chosen by the student.
Andrew Bell
Added greyscale thresholding and blurring
Blurring has options for median, mean and custom masks. Can be applied
with greyscaled image or rgb image and can also apply salt and pepper
noise to the image before hand. Access to features is via ?mode=blur or
?mode=thresholdgreyscale
Andrew Bell
Added gaussian blurring
Blur page now has ability to do gaussian blurring.
Andrew Bell
Moved noise adder to bottom of menu
Also added checkbox for absolute value option if using custom grid in
blur
Andrew Bell
Added Edge Detection interactive
Also did some refactoring of blur interactive
Andrew Bell
Added calculation of frames per second. Also changed markdownsection …
…to allow for multiple parameters in an interactive. Someone should probably check this for security and make sure I haven't broken any other interactives?
Andrew Bell
Added default pictures to choose from.
Picture picker will be supplied if Will be supplied if option
picturepicker is given.
Andrew Bell
Added caching
Scrolls through pictures much faster now.
Andrew Bell
Fixed cache size
Was using size of canvas rather than size of image as cache. Also
turned off animation.

@hayleyavw hayleyavw removed the content label Jun 8, 2017

@JackMorganNZ JackMorganNZ merged commit cdce43a into uccser:develop Feb 12, 2018

@JackMorganNZ JackMorganNZ referenced this pull request Feb 12, 2018

Merged

Release 2.12.0 #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment