Update Pixel Viewer interactive to support edge detection #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 7, 2016 00:15
activate. Turns pixels white or black based on a boolean equation chosen by the student.
Blurring has options for median, mean and custom masks. Can be applied with greyscaled image or rgb image and can also apply salt and pepper noise to the image before hand. Access to features is via ?mode=blur or ?mode=thresholdgreyscale
Blur page now has ability to do gaussian blurring.
Also added checkbox for absolute value option if using custom grid in blur
Also did some refactoring of blur interactive
…to allow for multiple parameters in an interactive. Someone should probably check this for security and make sure I haven't broken any other interactives?
Picture picker will be supplied if Will be supplied if option picturepicker is given.
Scrolls through pictures much faster now.
Was using size of canvas rather than size of image as cache. Also turned off animation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request merges in the work by Andrew Bell on updating the pixel viewer interactive to do edge detection. The logic has been added by the interface needs to be updated for improved usability.
Also this pull request has merge conflicts because the structure of the CSFG has changed since the work began.
This pull request is also the follow up/next step for #32.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the pull request. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your change.#???in your description to reference an issue, where???is the issue number)