Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show video symbol on video panels (fixes #814) #816

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Conversation

JackMorganNZ
Copy link
Member

@JackMorganNZ JackMorganNZ commented Jan 31, 2018

Requires #815 to be merged in first to provide positioning CSS rules. Also removes image positioning logic that never worked, it only added unmatched class names.

Fixes #814.

@JackMorganNZ JackMorganNZ added the frontend Related to the website the user sees label Jan 31, 2018
@JackMorganNZ JackMorganNZ added this to the 4.0.0 milestone Jan 31, 2018
@JackMorganNZ JackMorganNZ self-assigned this Jan 31, 2018
@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #816 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #816   +/-   ##
=======================================
  Coverage     99.5%   99.5%           
=======================================
  Files          102     102           
  Lines         3238    3238           
  Branches       383     383           
=======================================
  Hits          3222    3222           
  Misses           7       7           
  Partials         9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23aea7...eccb8cb. Read the comment docs.

@JackMorganNZ JackMorganNZ merged commit eccb8cb into develop Feb 2, 2018
@JackMorganNZ JackMorganNZ deleted the issue/814 branch February 5, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to the website the user sees
Development

Successfully merging this pull request may close these issues.

2 participants