Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow widgets creators to be restricted. #1198

Closed
FrenjaminBanklin opened this issue Feb 11, 2019 · 2 comments
Closed

Allow widgets creators to be restricted. #1198

FrenjaminBanklin opened this issue Feb 11, 2019 · 2 comments
Assignees
@FrenjaminBanklin
Milestone
Ifrit (Dev 5)

Comments

@FrenjaminBanklin
Copy link
Contributor

There is potential to create widgets that we would only want to be created by users with the basic_author role.

This would most likely be something defined in the install.yaml for a widget and adjustable later on through the admin panel. Widgets restricted thus shouldn't appear in the catalog for users who lack the appropriate role.
@FrenjaminBanklin
Copy link
Contributor Author

Also worth considering whether it should be possible for a person with the basic_author role to create one of these widgets and then share it with somebody who lacks the basic_author role - first assumption is that users without the role shouldn't be viable to share access to the widget with, but it's possible that at some point somebody might want to do that.

@FrenjaminBanklin FrenjaminBanklin self-assigned this Feb 11, 2019
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 12, 2019
@FrenjaminBanklin
ucfopen#1198 Made a migration to track whether a widget is restricted…
83de018 
… for student creation or not. Adjusted installer to account for a new install.yaml property corresponding to the new field. Adjusted widget catalog lookup to omit author_only widgets when non-author users are looking at the catalog. Fixed My Widgets page not properly disabling copy/delete buttons for users who lack appropriate access to a widget instance.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Feb 12, 2019
Merged
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 12, 2019
@FrenjaminBanklin
ucfopen#1198 Tweaked test for widget installer to expect new property.
0a61124
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Feb 18, 2019
Open
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 19, 2019
@FrenjaminBanklin
ucfopen#1198 Pivoted from restricting creation of widgets to restrict…
fd5a9de 
…ing who can publish widgets; rewrote migration, added checks etc. Added migration to keep track of the user who published a widget.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 19, 2019
@FrenjaminBanklin
ucfopen#1198 Some cleanup and one more little test.
5310d30
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 20, 2019
@FrenjaminBanklin
ucfopen#1198 Now checking if a widget is publishable by a user instea…
ee4bc96 
…d of if a widget instance is publishable by a user. Changed tests to match.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Feb 20, 2019
Closed
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 20, 2019
@FrenjaminBanklin
ucfopen#1198 Implementing last suggestion.
4e2b115
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 20, 2019
@FrenjaminBanklin
ucfopen#1198 Test assertion updated to check for new error message.
960e541
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Feb 22, 2019
@FrenjaminBanklin
ucfopen#1198 Changing name of API endpoint being used to verify that …
8a6fd41 
…a person can publish a widget type.
FrenjaminBanklin added a commit to FrenjaminBanklin/Materia that referenced this issue Mar 12, 2019
@FrenjaminBanklin
ucfopen#1198 Added Restrict Publish toggle to admin widget panel.
63e3b71
@clpetersonucf clpetersonucf mentioned this issue Apr 1, 2019
Merged
@iturgeon iturgeon added this to the Ifrit (~5) milestone Jun 3, 2019
@iturgeon
Copy link
Member

iturgeon commented Jun 3, 2019

Merged into Ifrit. Should ship soon, closing.

@iturgeon iturgeon closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrenjaminBanklin FrenjaminBanklin

Labels
None yet
Projects
None yet
Milestone
Ifrit (Dev 5)
Development

No branches or pull requests
2 participants
@iturgeon @FrenjaminBanklin