-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/settings dialog #1540
Issue/settings dialog #1540
Conversation
… guest access mode on a student made widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I left one request below based on displaying scores, but I'd also like to see some level of responsiveness added to the settings dialog. Currently, if a user is interacting with the dialog with a lower resolution display, the bottom of the dialog is cut off and prevents them from selecting the Save and Cancel options at the bottom.
I overlooked the fact that students should still be able to view guest scores, thank you! I added an I've also updated the setting dialog to be more responsive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox, 100% zoom, 1792px. I don't recall encountering this issue previously, but it definitely appears related to the addition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Really great work here: your solution to score display when a user becomes a student is inspired. It's non-destructive, still gives user score access, but decontextualizes the scores until/unless the student role is replaced.
Well done, I think this is good to go.
Fixes #1512
Fixes #1504
Additional
Continuation of #1516