Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1512-and-1504 #1516

Closed
wants to merge 9 commits into from
Closed

Conversation

cayb0rg
Copy link
Contributor

@cayb0rg cayb0rg commented Oct 5, 2023

Fixes #1512

  • Hides embedded only option for students and student made widgets and increases dialog's max-height

Fixes #1504

  • Went with the option of setting all of the user's instances to guest mode, since a user whose author status has been removed having access to graded widgets feels icky
  • Updates settings dialog view and edit permissions for grandfathered-in users

Additional

  • Added error message for when you try to remove guest access from a student-made widget in instance manager
  • Adds 'owner' tag to collaborator dialog

@cayb0rg cayb0rg changed the title Hides embedded only option and increases dialog height Issue/1512-and-1504 Oct 5, 2023
@cayb0rg cayb0rg marked this pull request as ready for review October 11, 2023 14:09
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the idea you had here - and I hate to put some cold water on it, but I think universally flipping all instances owned by the user to guest mode is too heavy-handed. The primary reason being that if a user once again receives the author role, we don't have a method to handle the inverse, and there may be widgets previously created that were set to guest mode intentionally that could be flipped to normal mode by accident.

Rather, I'm more inclined to retain all users' instance permissions, but make features and permissions in My Widgets a little more locked down for instances that are not student-made when the user is a student.

Instances in this "grandfathered-in" mode could have the following changes, potentially:

  • Attempt limits can ONLY be retained or modified to unlimited, and not any other value.
  • Access can ONLY be set to Guest Mode, but the current access mode can be retained.
  • Access to Student Activity is restricted (blocked)
  • Access to Export Options is restricted (either blocked outright, or only Questions & Answers is available)

I think it's pretty safe to assume that for instances students already have access to but aren't student-made, the implication is that the owner was once not a student. These restrictions are pretty targeted without being overly penalizing or inconvenient. Let me know how you feel about it - I'm more than happy to go over these restrictions more in-depth or come up with an alternative.

@clpetersonucf clpetersonucf changed the base branch from issue/support-dashboard-in-react to dev/10.0.1 October 12, 2023 18:29
@cayb0rg
Copy link
Contributor Author

cayb0rg commented Oct 18, 2023

I agree; setting all of a user's instances to guest mode could have repercussions and inverting it would be difficult. I've removed this action and updated the widget's page to do the following for once-author-now-student owners:

  • Can only set access to Guest Mode. Saving with Normal Mode will not boot them from the instance.
  • Can only set attempts to the current attempt number or Unlimited (will work on making the other options un-selectable - this is done)
  • Cannot see student scores but can export Questions and Answers (this seemed to be in place already for students)

@clpetersonucf clpetersonucf deleted the branch ucfopen:dev/10.0.1 October 26, 2023 17:34
@clpetersonucf
Copy link
Member

Deleting the ucfopen/dev/10.0.1 force-closed this PR (sorry!). You'll have to remake it and target the new dev/10.1.0 branch instead. I would add a reference to this PR so the prior history and comments can be tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants