Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Requester.request
response.text
(response.json()
internally callsresponse.text
) - the underlying issue is that the requests library relies onchardet
to determine the encoding of data, but it's impractically slow for binary data (which can occur whenFile.download
is called on a non-text file) so effectively hangsFile.get_contents
directlyFixes #386 .
Note: I added a test
test_request_get_binary
but couldn't find a way to make it work with theregister_uris
function in util by adding a fixture since JSON doesn't seem to support binary data.