94 scrub bad result handling #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufordrat
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the uses of
Result.get_ok, but replaced one case with a new possible exceptionHeaderRepresentationError. It is my opinion that, if this is triggered it should be critical, and it should be reported to the user that they should contact us if they ever get this error.As a reminder, part of the motivation of this issue was to deal with a bug that triggering an uncaught exception. This came from the fact that
mrmimewas putting line breaks into long file names in order to maintain the recommended margin of 80 characters. Upping the allowed line length fixed this problem.