Avoid reloading keywords protobuf on each load #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatlotus
force-pushed
the
prevent-reloading-keywords
branch
from
5c37b95
to
3ff5d9a
Compare
|
It seems to pass my rudimentary poking. Should I merge? |
fatlotus
added a commit
that referenced
this pull request
Mar 8, 2016
Avoid reloading keywords protobuf on each load
|
Bombs away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit of a hack, but it seems to reduce latency to around 600ms on the home page... as well as speeding up the API. I'm going to keep poking to see if there's anything else to cut out.
Before you merge- I'm a little worried about the feature impacts of this patch. I don't think this integration is tested (because the stubs don't handle this case), and I want to make sure this works in practice. I've played with the test instance somewhat, but can you test it as well?
https://prevent-reloading-keywords-dot-caravel-code-reviews.appspot.com