Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to new jaxdf #220

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Moving to new jaxdf #220

merged 8 commits into from
Nov 24, 2023

Conversation

astanziola
Copy link
Member

@astanziola astanziola commented Nov 22, 2023

Moving to new jaxdf version, which is based on equinox and the latest major plum release.

Others changes:

@astanziola astanziola changed the base branch from main to version-0.2 November 24, 2023 15:57
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6884aff) 80.34% compared to head (fb58c65) 80.61%.

Files Patch % Lines
jwave/geometry.py 89.18% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           version-0.2     #220      +/-   ##
===============================================
+ Coverage        80.34%   80.61%   +0.26%     
===============================================
  Files               14       15       +1     
  Lines             1155     1202      +47     
===============================================
+ Hits               928      969      +41     
- Misses             227      233       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astanziola astanziola marked this pull request as ready for review November 24, 2023 20:12
@astanziola astanziola merged commit 7d02164 into version-0.2 Nov 24, 2023
4 checks passed
@astanziola astanziola mentioned this pull request Dec 7, 2023
astanziola added a commit that referenced this pull request Dec 18, 2023
* removed missing function from test_geometry
* added setting class for time domain simulations (TimeWavePropagationSettings )
* upgraded jaxdf
* use jaxdf.Module
@astanziola astanziola deleted the equinox-and-update-plum branch January 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant