Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mention of MATLAB output file version 7.3 #291

Closed
Tracked by #292
samcunliffe opened this issue May 11, 2023 · 1 comment · Fixed by #310
Closed
Tracked by #292

Add a mention of MATLAB output file version 7.3 #291

samcunliffe opened this issue May 11, 2023 · 1 comment · Fixed by #310
Labels
documentation Improvements or additions to documentation enhancement New feature or request upstream Related to one of our dependencies
Milestone
End of ARC project.

Comments

@samcunliffe
Copy link
Member

Because MATLAB doesn't seem to use semver correctly, MATLAB file version 7.3 is the magic version for which everything works, and 7.0 is no good.

This should be explained somewhere in the user-facing docs. Possibly with screenshots of MATLAB for how to change the default.
@samcunliffe samcunliffe added documentation Improvements or additions to documentation enhancement New feature or request upstream Related to one of our dependencies labels May 11, 2023
@samcunliffe samcunliffe added this to the End of ARC project. milestone May 11, 2023
@willGraham01 willGraham01 mentioned this issue May 19, 2023
Closed
@samcunliffe samcunliffe mentioned this issue May 22, 2023
Merged
samcunliffe added a commit that referenced this issue May 22, 2023
@samcunliffe
Add explicit mention of .mat files version 7.3.
2c420ee 
Solves #291.
samcunliffe added a commit that referenced this issue May 22, 2023
@samcunliffe @willGraham01
Test-driven reading and writing basic datatypes to HDF5. (#310)
afb3596 
* Also test overwrite.

Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>

* Adding some HDF5 tests.

Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>

* Old API.

Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>

* Can read and write a matrix.

With unfortunate duplication of memory into buffers. To be fixed in the
future with flattened classes.

Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>

* Planceholder for fdtdgrid read in from .mat file

* It compiles.

* Add a smol fdtdgrid.mat file and make tests read from it

* Try to find that file

* This should do a work

* Apply suggestions from code review

* Make clang-format happy.

* Specify which H5::Exception.

* Remove unused function.

* Add explicit mention of .mat files version 7.3.

Solves #291.

* fdtdGridInitialiser reader is not implemented.

So SKIP the test and throw an std::logic_error.

* Rewording README

* spdlog function calls in source.

---------

Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: willGraham01 <1willgraham@gmail.com>
@samcunliffe samcunliffe linked a pull request May 22, 2023 that will close this issue
Test-driven reading and writing basic datatypes to HDF5. #310
Merged
@samcunliffe
Copy link
Member Author

Fixed by #310

@samcunliffe samcunliffe mentioned this issue May 22, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request upstream Related to one of our dependencies
Projects
None yet
Milestone
End of ARC project.
Development

Successfully merging a pull request may close this issue.

Test-driven reading and writing basic datatypes to HDF5. UCL/TDMS
1 participant
@samcunliffe