Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #440 #443

Merged
merged 7 commits into from
May 23, 2024
Merged

Fixes #440 #443

merged 7 commits into from
May 23, 2024

Conversation

aazeltan
Copy link
Contributor

@aazeltan aazeltan commented May 9, 2024

add winter 2024 events to archive page

@aazeltan aazeltan requested a review from jamesmwu May 9, 2024 03:15
Copy link
Contributor

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are some conflicts right now that are preventing the checks from passing-- would it be possible to resolve those? Thanks!

@ariyin
Copy link
Contributor

ariyin commented May 19, 2024

  • missing slides for hackathon 101
  • nit: intro to html, css, and js slides link to the second slide, should be linking to the very first slide
  • typo in kayla's last name
  • stackschool session 1 name should be intro to fullstack mobile development
  • wrong link for stackschool session 3, 4 readme?


- name: "Session 5: Backend Integration"
repo: https://github.com/uclaacm/stackschool-running_demo-w24/tree/main/session-5
slides: https://docs.google.com/presentation/d/1scnBk7kcKiTpBJjeSSCohgKtjVYsNcMyyCW69sotG0Y/edit#slide=id.g2b6396ae016_0_133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the slides for this link to slide 2 instead of 1. Everything else looks good though-- do you think you could change this, and then I'll go ahead and merge it into main? Thanks!

@jamesmwu jamesmwu self-requested a review May 23, 2024 00:44
Copy link
Contributor

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesmwu jamesmwu merged commit 30219a0 into main May 23, 2024
4 checks passed
@jamesmwu jamesmwu deleted the aazel/winter2024 branch May 23, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants