Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Spring 2024 events to archive #455

Merged
merged 4 commits into from
May 21, 2024
Merged

added Spring 2024 events to archive #455

merged 4 commits into from
May 21, 2024

Conversation

SPerrott22
Copy link
Contributor

HackCraft and learn.py from Spring 2024 are added to archive page

Fixes #452

HackCraft and learn.py
@SPerrott22 SPerrott22 self-assigned this May 20, 2024
@SPerrott22 SPerrott22 changed the title sam/Added Spring 2024 events to archive added Spring 2024 events to archive May 20, 2024
@SPerrott22 SPerrott22 requested a review from jamesmwu May 20, 2024 00:17
@SPerrott22 SPerrott22 assigned SPerrott22 and unassigned SPerrott22 and jamesmwu May 20, 2024
Copy link
Contributor

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only thing (which is kind of nitpicky) is could you add the "web scraping" tag to the learn.py session 1 tag? After that we should be good to merge this in. Thanks!

@SPerrott22 SPerrott22 requested a review from jamesmwu May 20, 2024 20:29
Copy link
Contributor

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesmwu jamesmwu merged commit b2b1ce3 into main May 21, 2024
4 checks passed
@jamesmwu jamesmwu deleted the sam/addS24Events branch May 21, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Workshop Archive Page for S24 Events
2 participants