Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Minor Update: Move 'X' button in Sidebar to leftside #234

Closed
Sahillather002 opened this issue Jan 19, 2024 · 0 comments
Closed

🐾 Minor Update: Move 'X' button in Sidebar to leftside #234

Sahillather002 opened this issue Jan 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Sahillather002
Copy link

Sahillather002 commented Jan 19, 2024

Context

We have a sidebar navigation that allows us to click the "X" or outside of the sidebar in order to close it.

image
image

Problem

When we click to open the sidebar on the far left, the 'X' is on the far right, which forces the user to navigate from left to right (bad UX). Instead, having it at the same place as the hamburger icon improves UX.

Note that the global text centering applies here, so that's why it's centered (and we made it right aligned rigidly)

Solution

Make the 'X' button left-aligned. You'll probably have to use both text-align:left and text-align:center explicitly or use flexbox.

Disclaimer: do not remove body { text-align: center; } It's a necessary evil, at this point in the project.

@EDWIN1669086 EDWIN1669086 changed the title 🚀 Feature: User experience 🚀 Feature: Move 'X' button in Sidebar to leftside Jan 19, 2024
@EDWIN1669086 EDWIN1669086 added the enhancement New feature or request label Jan 19, 2024
@EDWIN1669086 EDWIN1669086 changed the title 🚀 Feature: Move 'X' button in Sidebar to leftside 🐾 Minor Update: Move 'X' button in Sidebar to leftside Jan 23, 2024
@EDWIN1669086 EDWIN1669086 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants