Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run R CMD check weekly #143

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Run R CMD check weekly #143

merged 3 commits into from
Jul 24, 2023

Conversation

dan-knight
Copy link
Contributor

@dan-knight dan-knight commented Jul 22, 2023

Description

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.

  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have added the major changes included in this pull request to the NEWS under the next release version or unreleased, and updated the date. I have also updated the version number in DESCRIPTION according to semantic versioning rules.

  • Both R CMD build and R CMD check run successfully.

@dan-knight dan-knight added the testing Testing for existing functionality label Jul 22, 2023
@dan-knight dan-knight requested a review from a team as a code owner July 22, 2023 00:09
Copy link

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dan-knight dan-knight merged commit 982f2c7 into main Jul 24, 2023
3 checks passed
@dan-knight dan-knight deleted the danknight-check-weekly branch July 24, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing for existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants