Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change variant peptide FASTA header separator to space #52

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Change variant peptide FASTA header separator to space #52

merged 4 commits into from
Aug 10, 2021

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Aug 10, 2021 •
edited

  1. Changed variant peptide FASTA header separator to space
  2. Modularized the variant peptide pool
  3. Identified a bug that previously it failed to get the AminoAcidSeqRecord object from a set of it using get_equivalent. This seems to because of the direction of calling __eq__ when calling the __contains__ of set. Still don't understand, but was able to fix it in an ugly way.

Closes #49

@zhuchcn zhuchcn requested a review from lydiayliu August 10, 2021 06:35
@lydiayliu
Update mkdocs.yml
23b4385 
add `---` to yaml as header
@zhuchcn zhuchcn merged commit 59a3ea0 into main Aug 10, 2021
@zhuchcn zhuchcn deleted the czhu-update-call-peptide branch August 27, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydiayliu lydiayliu lydiayliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change FASTA header separator
2 participants
@zhuchcn @lydiayliu