Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v10.1.0 #314

Merged
merged 2 commits into from
May 16, 2024
Merged

Release v10.1.0 #314

merged 2 commits into from
May 16, 2024

Conversation

yashpatel6
Copy link
Contributor

Description

Minor release to make latest tool updates available

Checklist

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up the branch protection rule following the github standards before opening this pull request, or the branch protection rule has already been set up.

  • I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample with aligner setting to BWA-MEM2, HISAT2, and both. The paths to the test config files and output directories were attached in the Testing Results section.

@yashpatel6 yashpatel6 requested a review from a team as a code owner May 15, 2024 23:39
Copy link

Bleep bloop, I am a robot.

Alas, some of the Nextflow configuration tests failed!

test/configtest-F16.json

@ ["manifest","version"]
- "10.0.0"
+ "10.1.0"
@ ["params","log_output_dir"]
- "/tmp/outputs/align-DNA-10.0.0/a_mini_n2_picard/log-align-DNA-10.0.0-19970704T165655Z/"
+ "/tmp/outputs/align-DNA-10.1.0/a_mini_n2_picard/log-align-DNA-10.1.0-19970704T165655Z/"
@ ["params","output_dir_base"]
- "/tmp/outputs/align-DNA-10.0.0/a_mini_n2_picard"
+ "/tmp/outputs/align-DNA-10.1.0/a_mini_n2_picard"
@ ["report","file"]
- "/tmp/outputs/align-DNA-10.0.0/a_mini_n2_picard/log-align-DNA-10.0.0-19970704T165655Z//nextflow-log/report.html"
+ "/tmp/outputs/align-DNA-10.1.0/a_mini_n2_picard/log-align-DNA-10.1.0-19970704T165655Z//nextflow-log/report.html"
@ ["timeline","file"]
- "/tmp/outputs/align-DNA-10.0.0/a_mini_n2_picard/log-align-DNA-10.0.0-19970704T165655Z//nextflow-log/timeline.html"
+ "/tmp/outputs/align-DNA-10.1.0/a_mini_n2_picard/log-align-DNA-10.1.0-19970704T165655Z//nextflow-log/timeline.html"
@ ["trace","file"]
- "/tmp/outputs/align-DNA-10.0.0/a_mini_n2_picard/log-align-DNA-10.0.0-19970704T165655Z//nextflow-log/trace.txt"
+ "/tmp/outputs/align-DNA-10.1.0/a_mini_n2_picard/log-align-DNA-10.1.0-19970704T165655Z//nextflow-log/trace.txt"

If the above changes are surprising, stop and determine what happened.

If the above changes are expected, there are two ways to fix this:

  1. Automatically: Post a comment starting with "/fix-tests" (without the quotes) and I will update the tests for you (you must review my work afterwards).
  2. Manually: Follow these steps on Confluence.

Copy link

@Faizal-Eeman Faizal-Eeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yashpatel6
Copy link
Contributor Author

/fix-tests

Copy link

Bleep bloop, I am a robot.

I have updated all of the failing tests for you with 68ec044. You must review my work before merging this pull request!

@yashpatel6 yashpatel6 merged commit 19fe13b into main May 16, 2024
7 checks passed
@yashpatel6 yashpatel6 deleted the yashpatel-release-10.1.0 branch May 16, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants