Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Libcal endpoints for app #570

Merged
merged 7 commits into from
May 17, 2023
Merged

Add Libcal endpoints for app #570

merged 7 commits into from
May 17, 2023

Conversation

shu8
Copy link
Member

@shu8 shu8 commented May 14, 2023

This PR adds the following endpoints to the API:

  • /libcal/locations
  • /libcal/locations/:id/seats
  • /libcal/locations/:id/groupSpaces
  • /libcal/spaces/:id/reserve
  • /libcal/bookings
  • /libcal/bookings/cancel

so that users can now book Libcal individual/group study spaces through the UCL Assistant App.

Corresponding PR for the App: uclapi/ucl-assistant-app-flutter#1.

This PR must be merged and deployed before the app is merged and pushed to app stores.

Deployment: We'll need to add the Libcal Read & Write scopes to the UCL Assistant API app.

@shu8 shu8 marked this pull request as ready for review May 14, 2023 20:39
shu8 added 3 commits May 14, 2023 21:50
After a new booking is made/one is cancelled, it's reasonable to want to
show the latest data immediately, otherwise users might be confused.

The cache is only really needed for when someone is just swiping through
pages but not actively trying to do something with the bookings.
@shu8 shu8 merged commit 47cadfa into master May 17, 2023
1 check failed
@shu8 shu8 deleted the shu8/libcal branch May 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant