Dockerization changes for Adopt a Book #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhanutejags
commented
Jun 17, 2021
•
bhanutejags
commented
- Fixed mimemagic dependency issue by upgrading Rails, from 5.2.4 to 5.2.6.
- Dependency on mimemagic 0.3.x no longer valid rails/rails#41750
- Version 0.3.5 could not be found mimemagicrb/mimemagic#139
- Dockerization changes
Closed
hortongn
requested changes
Jun 25, 2021
There was a problem hiding this comment.
@bhanutejags Can we add some instructions to the README that explain how to start the application via Docker?
hortongn
requested changes
Jul 11, 2021
There was a problem hiding this comment.
@bhanutejags Looks good. Please squash the commits and rebase and I'll then merge.
* Fixed Docker publish failing. * Modified `Dockerfile`, To fix an issue with `COPY --chown`. * Added documentation for Dockerization. * Added CircleCI code to build and publish the Docker image to ECR. * Docker Image Publish to ECR is configured to only happen when the CircleCI is build is on the QA branch. * Fixed mimemagic dependency issue by upgrading Rails, from 5.2.4 to 5.2.6.
bhanutejags
force-pushed
the
61/docker-changes
branch
from
6a90ea4
to
3da53a5
Compare
…ocker-changes � Conflicts: � Gemfile.lock
Done. |
Done. |
hortongn
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.