Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 template not rendering properly #443

Closed
crowesn opened this issue Sep 28, 2018 · 0 comments
Closed

404 template not rendering properly #443

crowesn opened this issue Sep 28, 2018 · 0 comments
Assignees
@crowesn
Labels
status: review Issues with an open PR type: bug
Milestone
Sprint ending Oct...

Comments

@crowesn
Copy link
Contributor

crowesn commented Sep 28, 2018

Descriptive summary

Object not found error raise in common objects controller is causing runtime error because we deleted the public/404.html file

https://github.com/uclibs/ucrate/blob/develop/app/controllers/common_objects_controller.rb#L13

Link to related issues or prior related work here.
@crowesn crowesn added type: bug status: working Issues in progress labels Sep 28, 2018
@crowesn crowesn added this to the Sprint ending October 5, 2018 milestone Sep 28, 2018
@crowesn crowesn self-assigned this Sep 28, 2018
@crowesn crowesn mentioned this issue Sep 28, 2018
Merged
@crowesn crowesn added status: review Issues with an open PR and removed status: working Issues in progress labels Sep 28, 2018
hortongn added a commit that referenced this issue Oct 2, 2018
@hortongn
Merge pull request #444 from uclibs/bug/#443-render-404
8cc29b3 
render 404 error instead of template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowesn crowesn

Labels
status: review Issues with an open PR type: bug
Projects
None yet
Milestone
Sprint ending October 5, 2018
Development

No branches or pull requests
1 participant
@crowesn