Restore ORCID attribute on hyrax user object #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowesn
force-pushed
the
982/orcid-form-field
branch
5 times, most recently
from
42794e2
to
de0e646
Compare
crowesn
changed the title
crowesn
changed the title
crowesn
force-pushed
the
982/orcid-form-field
branch
from
de0e646
to
754f953
Compare
crowesn
commented
Nov 9, 2023
| end | ||
|
|
||
| it 'persists orcid id after editing' do |
There was a problem hiding this comment.
@Janell-Huyck this should fix it.
crowesn
force-pushed
the
982/orcid-form-field
branch
2 times, most recently
from
4461d58
to
f9d8513
Compare
crowesn
force-pushed
the
982/orcid-form-field
branch
from
f9d8513
to
c644570
Compare
Janell-Huyck
approved these changes
Nov 13, 2023
|
I am able to add an Orcid number in the profile page. |
|
After saving the update, the link is correctly displayed: |
|
View when I return to profile edit page: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #982
Restore user profile edit form fields and display for ORCID attribute on user object.
Changes proposed in this pull request: