Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1135/ HUT Include Devise::Test::ControllerHelpers for all types in rails_helper #1149

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Janell-Huyck
Copy link
Contributor

@Janell-Huyck Janell-Huyck commented Dec 21, 2023

Fixes #1135

Include Devise::Test::ControllerHelpers for all types in rails_helper.

The following testing error:

Failure/Error: <%= media_display https://github.com/presenter %>

ActionView::Template::Error:

came from not correctly loading the testing helpers from Devise. We had

  config.include Devise::Test::ControllerHelpers, type: :controller
  config.include Devise::Test::ControllerHelpers, type: :helper

in our rails_helper file, but we also needed:

  config.include Devise::Test::ControllerHelpers, type: :view

This PR combines the three types and loads all types by simplifying the loading to:

  config.include Devise::Test::ControllerHelpers

@Janell-Huyck Janell-Huyck changed the title Include Devise::Test::ControllerHelpers for all types in rails_helper 1135/ Include Devise::Test::ControllerHelpers for all types in rails_helper Dec 21, 2023
@Janell-Huyck Janell-Huyck changed the title 1135/ Include Devise::Test::ControllerHelpers for all types in rails_helper 1135/ HUT Include Devise::Test::ControllerHelpers for all types in rails_helper Dec 21, 2023
@scherztc scherztc merged commit dcb81ce into hyrax_3 Jan 3, 2024
1 check failed
@scherztc scherztc deleted the 1135/HUT-media-display-error branch January 3, 2024 16:41
@crowesn crowesn self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants