emscripten: disable big endian test #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase your pull request on top of latest master (which has fixes for the CI failures) ? |
This test should not run on the emscripten platform because of : https://github.com/emscripten-core/emscripten/blob/dff33368427fba16745c8ce52f11484a67b2855d/cmake/Modules/TestBigEndian.cmake#L5
|
Hi @rouault, thank you. Done. |
msabwat
added a commit
to msabwat/openjpeg
that referenced
this pull request
Jun 1, 2021
thanks to @ePirat, it turns out that !EMSCRIPTEN does not evaluate to 1 on other platforms, so the the uclouvain#1345 actually disabled the test for all platforms.
This was referenced Jun 1, 2021
rouault
added a commit
that referenced
this pull request
Jun 1, 2021
fix #1345: don't remove big endian test for other platforms
msabwat
added a commit
to msabwat/openjpeg
that referenced
this pull request
Jun 10, 2021
thanks to @ePirat, it turns out that !EMSCRIPTEN does not evaluate to 1 on other platforms, so the the uclouvain#1345 actually disabled the test for all platforms.
|
For the record, I think the solution here is not to change |
DanielHeath
pushed a commit
to radiopaedia/openjpeg
that referenced
this pull request
Sep 21, 2021
thanks to @ePirat, it turns out that !EMSCRIPTEN does not evaluate to 1 on other platforms, so the the uclouvain#1345 actually disabled the test for all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think this test should not run on the emscripten platform because of :
https://github.com/emscripten-core/emscripten/blob/dff33368427fba16745c8ce52f11484a67b2855d/cmake/Modules/TestBigEndian.cmake#L5
changing CMAKE_ROOT to point to
..,/emsdk/upstream/emscripten/cmakedoes not solve the issue, as there are some .cmake files that are needed and are not on emsdk.