Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lcms2 static linking using pgk config #867

Conversation

pseiderer
Copy link
Contributor

thirdparty: lcms2: append flags found by pkg-config if available

This change allows to get all required CFLAGS/LDFLAGS in case of static only
build.

Fixes a buildroot build failure (see [1], [2] and [3]).

[1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57
[2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html
[3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html

Signed-off-by: Peter Seiderer ps.report@gmx.net

Depends on #866

@rouault
Copy link
Collaborator

rouault commented Jan 4, 2021

could you rebase this so that CI tests are re-run ? Some of them apparently failed

This change allows to get all required CFLAGS/LDFLAGS in case of static only
build.

Fixes a buildroot build failure (see [1], [2] and [3]).

[1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57
[2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html
[3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Depends on uclouvain#866
@pseiderer pseiderer force-pushed the fix-lcms2-static-linking-using-pgk-config branch from 1f14781 to b6f0e41 Compare January 4, 2021 16:14
@rouault rouault merged commit 0782cd0 into uclouvain:master Jan 4, 2021
rouault added a commit to rouault/openjpeg that referenced this pull request Jun 27, 2022
…atic libraries are not in system directories (fixes uclouvain#1430)

Note that the fix might be partial only for static-only builds (cf
comments)

Ammends PR uclouvain#866 and uclouvain#867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants