-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BT: EPIC Frontend - School Dropdown #78
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we maintain certain convention of naming files or backend APIs throughout the team. Besides, all changes look good. Nice job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployment link would be appreciated
@whuang602 Please reassign the points label as most changes made by my teammate were mistakenly overwritten by me when I tried to resolve merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Storybook:
https://ucsb-cs156-w24.github.io/proj-organic-w24-6pm-4/prs/78/storybook/?path=/story/components-courses-courseform--create
Closes #32, #33, #34, #35, #37