Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BT: EPIC Frontend - Course Term Regex and Error #83

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

BT: EPIC Frontend - Course Term Regex and Error #83

wants to merge 53 commits into from

Conversation

AdmPenguin
Copy link
Contributor

@AdmPenguin AdmPenguin commented Mar 7, 2024 •
edited

  • Made it so that courses check regex based on school and return appropriate error message.

Dependent on PR #78, #80. Please close those first.

20240307_15h19m08s_grim

@AdmPenguin
bt - revert changes
25624fc
@AdmPenguin
Merge branch 'main' into bt-ep1f5
93dd1c0
@AdmPenguin
Update CourseForm.js
37b1641
@AdmPenguin
bt- Update CourseForm.js
0819d77
@AdmPenguin
bt - Update CourseForm.test.js
3299253
@AdmPenguin
bt - Update CourseForm.test.js
cc61bd2
@AdmPenguin
bt - Update CourseForm.test.js
cb90962
@AdmPenguin
bt - Update CourseForm.test.js
f8c0ee1
@AdmPenguin
Revert "bt - Update CourseForm.test.js"
60425fb 
This reverts commit f8c0ee1.
@AdmPenguin
Revert "bt - Update CourseForm.test.js"
5c48ba8 
This reverts commit cb90962.
@AdmPenguin
Revert "bt - Update CourseForm.test.js"
b77c95f 
This reverts commit cc61bd2.
@AdmPenguin
Revert "bt - Update CourseForm.test.js"
0c55a0a 
This reverts commit 3299253.
@AdmPenguin
Revert "bt- Update CourseForm.js"
6c8dc3e 
This reverts commit 0819d77.
@AdmPenguin
Revert "Update CourseForm.js"
41f5ece 
This reverts commit 37b1641.
@AdmPenguin
Revert "bt - revert changes"
9f49ceb 
This reverts commit 25624fc.
@AdmPenguin
bt - Update CourseForm.js
d58ccf9
@AdmPenguin
bt - Update CourseForm.test.js
ccc1133
golo230
golo230 previously approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@golo230 golo230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aavash-Adhikari Aavash-Adhikari self-requested a review March 18, 2024 21:20
Aavash-Adhikari
Aavash-Adhikari reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Aavash-Adhikari Aavash-Adhikari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. PRs 78 and 80 are good too, should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aavash-Adhikari Aavash-Adhikari Aavash-Adhikari left review comments

@luxiangzh luxiangzh luxiangzh left review comments

@golo230 golo230 golo230 left review comments

@scottpchow23 scottpchow23 Awaiting requested review from scottpchow23 scottpchow23 is a code owner

@andrewpengucsb andrewpengucsb Awaiting requested review from andrewpengucsb andrewpengucsb is a code owner

@AnikaArora AnikaArora Awaiting requested review from AnikaArora AnikaArora is a code owner

@sangitakunapuli sangitakunapuli Awaiting requested review from sangitakunapuli sangitakunapuli is a code owner

@tallyhawley tallyhawley Awaiting requested review from tallyhawley tallyhawley is a code owner

@Aasish-Virjala Aasish-Virjala Awaiting requested review from Aasish-Virjala Aasish-Virjala is a code owner

@whuang602 whuang602 Awaiting requested review from whuang602 whuang602 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AdmPenguin @luxiangzh @golo230 @Aavash-Adhikari @andrewpengucsb @whuang602