-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pc report controllers #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pconrad
force-pushed
the
pc-reportControllers
branch
from
August 6, 2023 19:04
da54537
to
9b1bc70
Compare
cleaned up some non-code text that shouldn't be there
LGTM |
pconrad
added a commit
that referenced
this pull request
Jun 7, 2024
Feature: Suspended field for users entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add swagger endpoints for:
Details
In practice, the InstructorReportJobSingleCommons would typically be used for an "on-demand" report, while the InstructorReportJob is more typically one that would be scheduled to run automatically every day. (A future enhancement would be to add an "Ending Date" for each game, and run the report only while the game is in progress; the same applies for the jobs to Milk the cows, and update cow health.)
To the ReportsController, we add two endpoints: one to retrieve Report rows by commons id, and another to retrieve ReportLine rows by their associated report id. These can be used in a future PR to implement the frontend by which an admin can see a report.