Pc reports page #62
Merged
Pc reports page #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support the need for an admin to look at a specific report in detail on its own page.
needed exact match, not substring match
needed check for class of button
pconrad
commented
Aug 8, 2023
pconrad
commented
Aug 8, 2023
pconrad
commented
Aug 8, 2023
pconrad
commented
Aug 8, 2023
pconrad
commented
Aug 8, 2023
GDW1
approved these changes
Aug 8, 2023
| @@ -9,6 +10,18 @@ export const parameters = { | |||
| actions: { argTypesRegex: "^on[A-Z].*" }, | |||
| } | |||
|
|
|||
| const currentUrl = window.location.href; | |||
| const isLocalhost = currentUrl.startsWith("http://localhost:6006/"); | |||
| const mockServiceWorkerUrl = isLocalhost ? "mockServiceWorker.js" : "https://" + window.location.hostname + "/mockServiceWorker.js"; | |||
There was a problem hiding this comment.
Im skeptical whether it is best practice to put ternary in a const var
There was a problem hiding this comment.
We discussed, and decided to leave this as it is.
|
|
||
| self.addEventListener('fetch', function (event) { | ||
| const { request } = event | ||
| const accept = request.headers.get('accept') || '' |
There was a problem hiding this comment.
consider using booleans instead of strings for readability
There was a problem hiding this comment.
This is "do not touch" code from msw framework.
| @@ -7,8 +7,11 @@ import LeaderboardPage from "main/pages/LeaderboardPage"; | |||
| import AdminUsersPage from "main/pages/AdminUsersPage"; | |||
| import AdminJobsPage from "main/pages/AdminJobsPage"; | |||
| import AdminCreateCommonsPage from "main/pages/AdminCreateCommonsPage"; | |||
| import AdminViewReportPage from "main/pages/AdminViewReportPage"; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR, we create a reports page where the Admin can view reports created by the InstructorReport job.
Merge these PRs first
Issues Addressed
Closes #18
Link to Storybook
TODO link to storybook
Details
This PR finishes work on the first draft of creating instructor reports.
/admin/reports/admin/reports/admin/reports/:report_id; that page uses theReportHeaderTableandReportDetailTableto show the results.Test Plan (for interactive testing)