Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc - add ReportHeaderTable.js and storybook entry for it #61

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

pconrad
Copy link
Contributor

@pconrad pconrad commented Aug 7, 2023

Overview

In this PR, we introduce frontend components that will be used to implement the instructor report.

The two new components are:

  • ReportHeaderTable, which displays rows from the reports table, and represents a snapshot of information about a Commons (i.e. one of the games being played). It is intended to display only one row at a time and appear at the top of a report about a specific commons.
  • ReportLineTable which displays lines from the report_lines table, each of which represents one player in the game, and a snapshot of their data at the time the report was made.

Issues Addressed

This is all in service of #18 but does not close it.

Storybook Links / Screenshots

image image

Details

We add storybook entries for table components that can display the header for a report (information from the Commons)
and the detail of the report (information from each UserCommons associated with that commons.)

These components will be used later in a page for the instructor report.

@pconrad pconrad marked this pull request as draft August 7, 2023 01:34
@pconrad pconrad marked this pull request as ready for review August 7, 2023 17:05
@pconrad pconrad mentioned this pull request Aug 7, 2023
6 tasks
Copy link
Contributor

@GDW1 GDW1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant see any changes I'd make

@pconrad pconrad merged commit 9643f22 into main Aug 7, 2023
9 checks passed
pconrad added a commit that referenced this pull request Aug 31, 2023
FIX: Removed 404 Error Page on Navigation and Reload
pconrad pushed a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants