DIGREPO-807: use FA icons for objects without thumbnails #36
Conversation
| position: unset; | ||
| width: unset; | ||
|
|
||
| a > img { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 6
There was a problem hiding this comment.
Yeah well blame Blacklight for that.
| // JIRA: DIGREPO-807 | ||
| #documents .grid .document .thumbnail { | ||
| border: none; | ||
| max-width: 100px; |
There was a problem hiding this comment.
Properties should be ordered border, max-height, max-width, position, width
| // gallery thumbnails | ||
| // JIRA: DIGREPO-807 | ||
| #documents .grid .document .thumbnail { | ||
| border: none; |
There was a problem hiding this comment.
border: 0 is preferred over border: none
| @@ -572,6 +572,24 @@ table#downloads { | |||
| // Blacklight | |||
| // ---------- | |||
|
|
|||
| // gallery thumbnails | |||
| // JIRA: DIGREPO-807 | |||
| #documents .grid .document .thumbnail { | |||
There was a problem hiding this comment.
Avoid using id selectors
Selector should have depth of applicability no greater than 2, but was 4
| id: match[1], | ||
| unicodeHex: match[2], | ||
| unicodeDec: parseInt(match[2], 16) | ||
| }) |
| function parseIconListFromLess(lines) { | ||
| lines = lines.toString(); | ||
| var match, result = []; | ||
| while (match = LESS_VARIABLE_REGEX.exec(lines)) { |
There was a problem hiding this comment.
Expected a conditional expression and instead saw an assignment.
| unicodeHex: icon.unicodeHex, | ||
| unicodeDec: icon.unicodeDec, | ||
| data: fontData[icon.unicodeDec].data | ||
| } |
| return Promise.map(params.sizes, function (siz) { | ||
| mkdirp.sync(pathModule.join(params.destFolder, params.color, 'png', siz)); | ||
| return generatePng(siz, name, params); | ||
| }, {concurrency: process.env['JOBS'] || 4}); |
There was a problem hiding this comment.
['JOBS'] is better written in dot notation.
|
|
||
| work.push(Promise.map(iconConfigs, generateIcon, {concurrency: 1}).then(function (done) { | ||
| console.log("Done",done.map(function (doneItem) { | ||
| return doneItem.color + " " + doneItem.id |
| optipng: optipng, | ||
| destFolder: destFolder | ||
| }); | ||
| }) |
| position: unset; | ||
| width: unset; | ||
|
|
||
| a > img { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 6
| @@ -572,6 +572,24 @@ table#downloads { | |||
| // Blacklight | |||
| // ---------- | |||
|
|
|||
| // override blacklight-gallery | |||
| // JIRA: DIGREPO-807 | |||
| #documents .grid .document .thumbnail { | |||
There was a problem hiding this comment.
Avoid using id selectors
Selector should have depth of applicability no greater than 2, but was 4
| @@ -502,7 +502,7 @@ footer { | |||
|
|
|||
| .document-thumbnail img { | |||
| float: right; | |||
| max-height: 200px; | |||
| max-height: 100px; | |||
There was a problem hiding this comment.
Properties should be ordered float, margin-top, max-height
| # The ordering of the field names is the order of the display | ||
| config.add_index_field solr_name("work_type_label", :stored_searchable), | ||
| label: "Format" | ||
|
|
||
| config.add_index_field solr_name("collection_label", :symbol), | ||
| label: "Collection" | ||
| label: "In Collection" |
There was a problem hiding this comment.
@chrissyrissmeyer is this OK? I figured since Collections themselves are part of the search results list, saying In Collection would be less ambiguous.
There was a problem hiding this comment.
Ran this by Tom B. as well, and he and I both agree that, grammatically, "In Collection" is weird. We both prefer "Collection" and don't feel the meaning of that field it is ambiguous. Additionally, this change would mean that search results labeling would be inconsistent with object view labeling (we use "Collection" on the object view page).
|
New LQQK
|
| @@ -175,6 +175,12 @@ def enforce_show_permissions(_opts = {}) | |||
| config.add_index_field solr_name("issued", :displayable), | |||
| label: "Issued Date" | |||
|
|
|||
| config.add_index_field solr_name("description", :stored_searchable), | |||
| label: "Summary", | |||
| if: :collection? | |||
There was a problem hiding this comment.
Descriptions are often way too long for non-Collections, especially in the case of ETDs.
| @@ -1,7 +0,0 @@ | |||
| <% desc = collection['description_tesim'] %> | |||
There was a problem hiding this comment.
Overriding the default partial here is why Collections rendered so differently in search results, with no item number and special formatting.
|
|
|
Wait are you kidding me, it uses the thumbnail for the slideshow as well. |
|
I think this is something that needs to be fixed in blacklight-gallery, so that we can use a thumbnail for the pane view and the full-size for the actual slideshow. |
dunn
changed the title
| @@ -0,0 +1,20 @@ | |||
| module Blacklight::GalleryHelper | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
|
OK, fixed it to show the larger (400px) images in the slideshow itself: |
|
Oh so sweet! 🍬 |
| render_thumbnail_tag( | ||
| document, | ||
| options, | ||
| url_options.reverse_merge(suppress_link: true) |
There was a problem hiding this comment.
url_options should just be options
|
For future reference, Blacklight added support for more flexible thumbnail settings: |
No description provided.