Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Herm71/issue252 #265

Merged
merged 6 commits into from Oct 26, 2023
Merged

Herm71/issue252 #265

merged 6 commits into from Oct 26, 2023

Conversation

Herm71
Copy link
Member

@Herm71 Herm71 commented Sep 6, 2023

What does this do/fix?

edits the accordion.css file to replace the details target with a class, ucsc-block-accordion

QA

Links to relevant issues
Issue #252

Links to deployed, scaffolded demo:
N/A

Screenshots/video:
N/A

Tests

Does this have tests?

  • Yes
  • No, this doesn't need tests because... it's a stylesheet change
  • No, I need help figuring out how to write the tests.

@Herm71
fix: 🐛 Theme accordion styles conflict with Details block in ucsc-con…
3b08bf4 
…tent-blocks plugin Fixes #252
@Herm71
fix: 🎨 replace <details> element with a class. Fixes #252
7e5ce14 
Theme accordion styles conflict with Details block in ucsc-content-blocks plugin  Fixes #252
@Herm71
merge conflict
72211e6
@Herm71 Herm71 self-assigned this Sep 6, 2023
@Herm71 Herm71 requested a review from knice September 6, 2023 20:28
@Herm71 Herm71 added the change Change to an existing but not broken feature label Sep 6, 2023
@knice knice merged commit 58aed36 into main Oct 26, 2023
@Herm71 Herm71 deleted the Herm71/issue252 branch October 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knice knice knice approved these changes

Assignees

@Herm71 Herm71

Labels
change Change to an existing but not broken feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Herm71 @knice