Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Document loading db schema in docker dev/test environments #511

Merged
merged 3 commits into from
Aug 6, 2018

Conversation

mcritchlow
Copy link
Member

@mcritchlow mcritchlow commented Aug 6, 2018

Local Checklist

  • Code style checked?
  • QA-ed locally?
  • Rebased with master branch?
  • Documentation updated (if needed)?

What does this PR do?

  • Documents the change to use db:schema:load instead of db:migrate when using Docker for dev/test work. This is not only faster, but also ensures the db/schema.rb file doesn't get updated, which should really only happen when we add new migrations.
  • Documents removing docker volumes along with containers.
  • Updates CircleCI config to use db:schema:load for consistency (and minor speed gain)
Why are we doing this? Any context of related work?
  • Prevent accidental commits of modified db/schema.rb file. And speed.

Where should a reviewer start?

  • docker/README.md

Manual testing steps?

  • Feel free to run this locally and confirm if you're up for it.

@ucsdlib/developers - please review

This not only won't change the schema file, it is apparently faster.
@hweng
Copy link
Contributor

hweng commented Aug 6, 2018

👍

1 similar comment
@VivianChu
Copy link
Member

👍

@mcritchlow
Copy link
Member Author

@ucsdlib/developers - thanks for your patience. got circleci using the new db:schema:load command as well now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.655% when pulling 14773aa on docker-db-schema into a6bf0cb on develop.

@lsitu
Copy link
Member

lsitu commented Aug 6, 2018

👍

@lsitu lsitu merged commit 1e7ecea into develop Aug 6, 2018
@lsitu lsitu deleted the docker-db-schema branch August 6, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants